Merge ~jjo/layer-snap:jjo-add-setup_py into ~stub/layer-snap:master

Proposed by JuanJo Ciarlante
Status: Rejected
Rejected by: Stuart Bishop
Proposed branch: ~jjo/layer-snap:jjo-add-setup_py
Merge into: ~stub/layer-snap:master
Diff against target: 39 lines (+28/-0)
2 files modified
lib/charms/layer/__init__.py (+0/-0)
setup.py (+28/-0)
Reviewer Review Type Date Requested Status
Stuart Bishop Approve
Review via email: mp+318294@code.launchpad.net

Commit message

[jjo] add basic setup.py and charms/layer/__init__.py

To post a comment you must log in.
Revision history for this message
JuanJo Ciarlante (jjo) wrote :

Need to use at e.g. test_requirements.txt:
-e git+https://git.launchpad.net/layer-snap#egg=charms.layer

Revision history for this message
Stuart Bishop (stub) wrote :

Ok. This seems like a hack, but one I can live with at my end.

review: Approve
Revision history for this message
Stuart Bishop (stub) wrote :

I rolled this back. Adding lib/charms/layer/__init__.py breaks the basic layer, which uses that file to provide the charms.layer.options datastructure.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/charms/layer/__init__.py b/lib/charms/layer/__init__.py
0new file mode 1006440new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/lib/charms/layer/__init__.py
diff --git a/setup.py b/setup.py
1new file mode 1007551new file mode 100755
index 0000000..79f7858
--- /dev/null
+++ b/setup.py
@@ -0,0 +1,28 @@
1#!/usr/bin/env python
2
3import os
4from setuptools import setup
5
6here = os.path.abspath(os.path.dirname(__file__))
7
8with open(os.path.join(here, 'README.md')) as f:
9 README = f.read()
10
11setup(name='layer_snap',
12 version='0.0.1',
13 description='layer_snap',
14 long_description=README,
15 license='Apache License 2.0',
16 classifiers=[
17 "Development Status :: 4 - Beta",
18 "Intended Audience :: Developers",
19 "Programming Language :: Python :: 2",
20 "Programming Language :: Python :: 2.7",
21 "Programming Language :: Python :: 3",
22 ],
23 url='https://git.launchpad.net/layer-snap',
24 package_dir={'': 'lib'},
25 packages=['charms/layer'],
26 include_package_data=True,
27 zip_safe=False,
28 )

Subscribers

People subscribed via source and target branches