Code review comment for lp:~jjo/juju-deployer/implement-series-cli-override

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

there's something a bit strange here which the tests note as part of their workaround, namely the deployment is using the value prior to its override, which makes this feels a bit icky/nondeterministic ie. runtime value changing while being used. the cleaner way would be to override this as the deployment is being constructed in configstack.

review: Needs Fixing

« Back to merge proposal