Juju Charms Collection
ubuntu package

Code review comment for lp:~jjo/charms/trusty/ubuntu/add-execd-and-charmhelpers-syncing

  1. Trusty Tahr (14.04)
  2. add-execd-and-charmhelpers-syncing
  3. Merge into trunk
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thank you for your work on this.

To-date, the Ubuntu charm has been maintained strictly as a hookless, ultra-simplistic charm.

## UNIT TESTS
With this being the first python code in the charm, I think that unit tests should also accompany those changes, even as simple as they are.

For example, the execd_preinstall() helper is represented in the cinder and neutron-api charms as install hook unit tests. Something similar should be done here so that reviewers of this proposal, and future reviewers, will have that to lean on.

## AMULET TESTS
The amulet test passes for Precise, Trusty, Vivid and Wily, indicating that the proposed changes do not impact basic functionality of the Ubuntu charm.

review: Needs Resubmitting
Reply

« Back to merge proposal