Juju Charms Collection
mongodb package

Code review comment for lp:~jjo/charms/trusty/mongodb/jjo-lp1274947-use_private-address_at_rs-initiate

  1. Trusty Tahr (14.04)
  2. jjo-lp1274947-use_private-address_at_rs-initiate
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

This seems fine to me, but I'm not clear how best to test this. Should I be able to replicate this on local provider, or does it require the MAAS bug? It would be best if we could "fudge" this enough to add a test case for this, but that seems like it would be difficult, if not impossible, to achieve.

Anyway, it doesn't seem to have any issues in the normal (non-bug) case, so it gets my +1.

review: Approve
Reply

« Back to merge proposal