Merge lp:~jjesse/ubuntu-packaging-guide/fixes-bug978493 into lp:ubuntu-packaging-guide

[Jonathan Jesse]

Proposing a fix to 978493 replaced bzr commit with debcommit

[Daniel Holbach (dholbach)]

Thanks for your work on this.

I just checked and there's a number of other occurences, where we might want to make sure that 'debcommit' is used. Generally wherever debian/changelog already contains the documentation of the change, 'debcommit' can be uesd safely.

Would you mind reviewing the guide again and see if we need to update other places as well?

daniel@daydream:~/bzr/ubuntu-packaging-guide$ grep -r "bzr commit" ubuntu-packaging-guide/ | grep -v -- "-m"
ubuntu-packaging-guide/patches-to-packages.rst: $ bzr commit
ubuntu-packaging-guide/udd-sponsorship.rst:<link-via-changelog>` using ``dch`` and ``bzr commit``. However, the branch
ubuntu-packaging-guide/udd-sponsorship.rst: $ bzr commit
ubuntu-packaging-guide/udd-uploading.rst: $ bzr commit --author "Bob Dobbs <email address hidden>"
ubuntu-packaging-guide/udd-working.rst: bzr commit
ubuntu-packaging-guide/udd-latest.rst:revert``. Once you are happy with the changes then use ``bzr commit``.
daniel@daydream:~/bzr/ubuntu-packaging-guide$

review: Needs Information

[Jonathan Jesse (jjesse)]

Yes I will make sure all references are right
On May 29, 2012 3:35 AM, "Daniel Holbach" <email address hidden> wrote:

> Review: Needs Information
>
> Thanks for your work on this.
>
> I just checked and there's a number of other occurences, where we might
> want to make sure that 'debcommit' is used. Generally wherever
> debian/changelog already contains the documentation of the change,
> 'debcommit' can be uesd safely.
>
> Would you mind reviewing the guide again and see if we need to update
> other places as well?
>
> daniel@daydream:~/bzr/ubuntu-packaging-guide$ grep -r "bzr commit"
> ubuntu-packaging-guide/ | grep -v -- "-m"
> ubuntu-packaging-guide/patches-to-packages.rst: $ bzr commit
> ubuntu-packaging-guide/udd-sponsorship.rst:<link-via-changelog>` using
> ``dch`` and ``bzr commit``. However, the branch
> ubuntu-packaging-guide/udd-sponsorship.rst: $ bzr commit
> ubuntu-packaging-guide/udd-uploading.rst: $ bzr commit --author "Bob
> Dobbs <email address hidden>"
> ubuntu-packaging-guide/udd-working.rst: bzr commit
> ubuntu-packaging-guide/udd-latest.rst:revert``. Once you are happy with
> the changes then use ``bzr commit``.
> daniel@daydream:~/bzr/ubuntu-packaging-guide$
>
> --
>
> https://code.launchpad.net/~jjesse/ubuntu-packaging-guide/fixes-bug978493/+merge/107574
> You are the owner of lp:~jjesse/ubuntu-packaging-guide/fixes-bug978493.
>

[Jonathan Jesse (jjesse)]

In patches-to-packages it is dealing w/ a branch and is ok, doesn't need to be changed to debcomit

In udd-sponsorship it is talking about bazaar and is correct

In udd-working it is talking about bazar and is correct

In udd-uploading this is correct for bzr commit

So it looks like it should be good to

Let me know

[Daniel Holbach (dholbach)]

Thanks a lot, merged!

review: Approve

=== modified file 'ubuntu-packaging-guide/fixing-a-bug.rst'
--- ubuntu-packaging-guide/fixing-a-bug.rst	2012-05-21 10:31:14 +0000
+++ ubuntu-packaging-guide/fixing-a-bug.rst	2012-05-28 02:22:19 +0000
@@ -181,7 +181,7 @@
 
 With the changelog entry written and saved, you can just run::
 
-  bzr commit
+  debcommit
 
 and the change will be committed (locally) with your changelog entry as a 
 commit message.