Code review comment for lp:~jimpop/mailman/mailman-auto-mod-verbose-members

Revision history for this message
Mark Sapiro (msapiro) wrote :

I have merged this branch and made some changes. The most significant is your code to drop old times from the recentMemberPostings dictionary is wrong. Deleting items from a list while processing 'for item in list' results in skipping items.

I also allow for different lists to have different member_verbosity_interval settings and process that I hope reasonably.

Finally, I don't attempt to moderate a non-member, and I look at more than the From: of the message to find a member address.

« Back to merge proposal