Code review comment for lp:~jimmiebtlr/juju-core/fix-no-peers-charms

Revision history for this message
William Reade (fwereade) wrote :

LGTM, I'm approving this despite the unnecessary lines in the test. A
followup that just dropped those would be very much appreciated.

https://codereview.appspot.com/101810046/diff/20001/charm/meta_test.go
File charm/meta_test.go (right):

https://codereview.appspot.com/101810046/diff/20001/charm/meta_test.go#newcode407
charm/meta_test.go:407: empty_input.Requires = nil
Aren't these nil already?

https://codereview.appspot.com/101810046/

« Back to merge proposal