31 @@ -353,6 +359,7 @@ 32 vpath[len(vpath)-1] = fmt.Sprint(k.Interface()) 33 newv, err := c.value.Coerce(rv.MapIndex(k).Interface(), vpath) 34 if err != nil { 35 + 36 return nil, err 37 } 38 out[newk.(string)] = newv
I think this is a spurious change.
I'm a bit surprised we don't have a direct test of schema/* that would fit this change. I believe you have it covered, but only at the charm level. Is there a test in schema that you could add that would be a bit more of a direct test?
Otherwise, LGTM.
« Back to merge proposal
31 @@ -353,6 +359,7 @@ k.Interface( )) Coerce( rv.MapIndex( k).Interface( ), vpath)
32 vpath[len(vpath)-1] = fmt.Sprint(
33 newv, err := c.value.
34 if err != nil {
35 +
36 return nil, err
37 }
38 out[newk.(string)] = newv
I think this is a spurious change.
I'm a bit surprised we don't have a direct test of schema/* that would fit this change. I believe you have it covered, but only at the charm level.
Is there a test in schema that you could add that would be a bit more of a direct test?
Otherwise, LGTM.