Code review comment for lp:~jimbox-comcast/mvhub/remove_additional_seq

Revision history for this message
Dan MacNeil (omacneil) wrote :

The old version of 004_remove_unused_tables_and_seq.sql (now in trunk)

...did some stuff and set version_log.version =4

The new version does **more** stuff, but under many circumstances this will never be called.

If a version_log.version == 4, 004_remove_unused_tables_seq.sql won't be run.

You need to put the new stuff in 006_remove_more_unused_seq.sql

In app-mvhub/project-tools/bin/mv_update_development the database is DROPped , new data is loaded and all the schema updating scripts in app-mvhub/setup/database/sql are run.

In production, we don't care to wipe old data, so only the new, unrun sql scripts are run.

Make fix & push branch

review: Needs Fixing

« Back to merge proposal