Code review comment for lp:~jimbaker/pyjuju/standardize-log-testing

On Tue, Jun 14, 2011 at 1:44 PM, Gustavo Niemeyer <email address hidden>wrote:

> Review: Needs Information
> This looks like a nice clean up, thanks Jim.
>
> One question:
>
> [1]
>
> 8 - yield ServiceStateManagerTestBase.setUp(self)
> 9 - yield ControlToolTest.setUp(self)
> 10 - self.save_logging()
> 11 + yield super(StatusTestBase, self).setUp()
> 12 + self.log = self.capture_logging()
>
> Have you checked that _all_ of the base classes conform to this protocol,
> yielding on
> every call to setUp? If one does not, we'll have issues.
>

I have rechecked that, and yes, they all conform to the cooperative
inheritance protocol. This was addressed in r120 in trunk for all ancestor
classes here. We may want to scan other test classes to see if there's been
other slippage since then, of course with any possible fixes in a different
branch.