pyjuju

Code review comment for lp:~jimbaker/pyjuju/charm-format-2

  1. charm-format-2
  2. Merge into trunk
Revision history for this message
William Reade (fwereade) wrote :

Damn, I'm sorry, I had an unpublished LGTM sitting here for days :(((.

https://codereview.appspot.com/6308044/diff/11004/juju/hooks/tests/test_invoker.py
File juju/hooks/tests/test_invoker.py (right):

https://codereview.appspot.com/6308044/diff/11004/juju/hooks/tests/test_invoker.py#newcode511
juju/hooks/tests/test_invoker.py:511: @defer.inlineCallbacks
Heh, nice catches :).

https://codereview.appspot.com/6308044/diff/11004/juju/lib/format.py
File juju/lib/format.py (right):

https://codereview.appspot.com/6308044/diff/11004/juju/lib/format.py#newcode144
juju/lib/format.py:144: os.environ.get("_JUJU_CHARM_FORMAT", "1")))
Thanks, all this is much clearer.

https://codereview.appspot.com/6308044/

« Back to merge proposal