Code review comment for lp:~jimbaker/pyjuju/charm-format-2

Revision history for this message
Jim Baker (jimbaker) wrote :

On 2012/06/06 02:18:58, niemeyer wrote:
> On further thinking, if the environment variable makes the change
simpler, we
> may as well just do it. Can we please make this purely an
implementation detail,
> though: call it _JUJU_CHARM_FORMAT, no docs. How does that sound?

I like this suggestion: _JUJU_CHARM_FORMAT properly suggests this
environment variable is an implementation detail. The use of the env var
does simplify the implementation.

https://codereview.appspot.com/6308044/

« Back to merge proposal