Code review comment for lp:~jimbaker/juju-jitsu/unit-test

Revision history for this message
Benji York (benji) wrote :

Thanks for this subcommand, Jim. Nicola and I have been using it to write some tests (see a first cut at lp:~juju-gui/charms/precise/juju-gui/trunk). A few remarks follow.

The charm directory name has to be the same as the charm name itself, which makes testing different branches difficult. Is revisiting that requirement possible?

It seems to us that the exit code from each one of the *.test files should be propagated and reported by the test subcommand (e.g., if any test returns a non-zero then Jitsu should return non-zero).

Bootstrapping from within the command either causes errors or times out: one needs to bootstrap in advance and use the --no-bootstrap option.

When accessing machines for log retrieval, rsync asks for a password for ubuntu@localhost. We can not figure out what that password should be.

We would appreciate any information you can give us about the above. Thanks.

« Back to merge proposal