Merge lp:~jibel/ubuntu-qa-tools/preinstalled_omap into lp:ubuntu-qa-tools

Proposed by Jean-Baptiste Lallement
Status: Merged
Merged at revision: 566
Proposed branch: lp:~jibel/ubuntu-qa-tools/preinstalled_omap
Merge into: lp:ubuntu-qa-tools
Diff against target: 89 lines (+40/-20)
1 file modified
dl-ubuntu-test-iso/dl-ubuntu-test-iso (+40/-20)
To merge this branch: bzr merge lp:~jibel/ubuntu-qa-tools/preinstalled_omap
Reviewer Review Type Date Requested Status
Michael Vogt Approve
Review via email: mp+58307@code.launchpad.net

Description of the change

This adds support for no-default archs powerpc, amd64+mac, armel+omap and armel+omap4.
Which means that these archs need to be specified on the command line to be downloaded and by default only amd64 and i386 will be used.

To post a comment you must log in.
568. By Jean-Baptiste Lallement

removed a debugging line

Revision history for this message
Michael Vogt (mvo) wrote :

Looks good, I merged this into the ubuntu branch now

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'dl-ubuntu-test-iso/dl-ubuntu-test-iso'
--- dl-ubuntu-test-iso/dl-ubuntu-test-iso 2011-04-01 18:46:19 +0000
+++ dl-ubuntu-test-iso/dl-ubuntu-test-iso 2011-04-19 13:54:29 +0000
@@ -1,4 +1,10 @@
1#!/usr/bin/python1#!/usr/bin/python
2#
3# Written by Steve Beattie <sbeattie@ubuntu.com>
4# Copyright 2010-2011 Canonical Ltd.
5# Licensed under the GNU General Public License, version 3.
6#
7
2from __future__ import with_statement # This isn't required in Python 2.6, but must be8from __future__ import with_statement # This isn't required in Python 2.6, but must be
3 # in the beginning and thus can't be conditional9 # in the beginning and thus can't be conditional
410
@@ -415,7 +421,15 @@
415421
416 for count, image in enumerate(image_factory(wanted)):422 for count, image in enumerate(image_factory(wanted)):
417 release, flavor, variant, arch = image423 release, flavor, variant, arch = image
418 isoname = release + '-' + variant + '-' + arch + '.iso'424 if variant == 'preinstalled' and 'omap' in arch:
425 subflavor = flavor.name.split('-')
426 if len(subflavor) == 2:
427 subvariant = variant + "-" + subflavor[1]
428 else:
429 subvariant = variant + "-desktop"
430 isoname = release + '-' + subvariant + '-' + arch + '.img.gz'
431 else:
432 isoname = release + '-' + variant + '-' + arch + '.iso'
419 hashsuffix = "." + release + '-' + variant433 hashsuffix = "." + release + '-' + variant
420 path = computepath(wanted, flavor, release, variant)434 path = computepath(wanted, flavor, release, variant)
421 if config.mirror:435 if config.mirror:
@@ -523,25 +537,7 @@
523 variantpaths['netbook'] = 'daily-live'537 variantpaths['netbook'] = 'daily-live'
524 variantpaths['moblin-remix'] = 'daily-live'538 variantpaths['moblin-remix'] = 'daily-live'
525 variantpaths['mobile'] = 'daily-live'539 variantpaths['mobile'] = 'daily-live'
526540 variantpaths['preinstalled'] = 'daily-preinstalled'
527 Flavor('ubuntu', use_prefix=False)
528 Flavor('ubuntu-server', variants=['server'])
529 Flavor('kubuntu')
530 Flavor('kubuntu-kde4', releases=['hardy'], variants=['desktop', 'alternate'])
531 Flavor('edubuntu', variants=['addon', 'dvd'])
532 Flavor('xubuntu', variants=['desktop', 'alternate'])
533 Flavor('ubuntustudio', variants=['alternate'])
534 Flavor('jeos', releases=['hardy'], variants=['jeos'], archs=['i386'])
535 Flavor('gobuntu', releases=['hardy'], variants=['alternate'])
536 Flavor('mythbuntu', variants=['desktop'])
537 Flavor('ubuntu-mid', variants=['usb'], archs=['lpia'])
538 Flavor('ubuntu-netbook', variants=['netbook'], archs=['i386'])
539 Flavor('kubuntu-netbook', variants=['netbook'], archs=['i386'])
540 Flavor('kubuntu-mobile', variants=['mobile'], archs=['i386'])
541 Flavor('ubuntu-moblin-remix', variants=['moblin-remix'], archs=['i386'])
542
543 default['variants'] = variantpaths.keys()
544 default['flavors'] = flavors.keys()
545541
546 parser = OptionParser()542 parser = OptionParser()
547 parser.add_option('-n', '--no-act', default=False, action='store_true', dest='no_act', help='compute everything but don\'t actually download')543 parser.add_option('-n', '--no-act', default=False, action='store_true', dest='no_act', help='compute everything but don\'t actually download')
@@ -572,6 +568,30 @@
572 parser.error("incorrect number of arguments")568 parser.error("incorrect number of arguments")
573 file_cfg = read_config(config.config)569 file_cfg = read_config(config.config)
574570
571 # Allows the download of non-default archs (see image_factory)
572 default['archs'].extend(config.arch)
573 default['variants'].extend(config.variant)
574
575 Flavor('ubuntu', use_prefix=False)
576 Flavor('ubuntu-server', variants=['server'])
577 Flavor('kubuntu')
578 Flavor('kubuntu-kde4', releases=['hardy'], variants=['desktop', 'alternate'])
579 Flavor('edubuntu', variants=['addon', 'dvd'])
580 Flavor('xubuntu', variants=['desktop', 'alternate'])
581 Flavor('ubuntustudio', variants=['alternate'])
582 Flavor('jeos', releases=['hardy'], variants=['jeos'], archs=['i386'])
583 Flavor('gobuntu', releases=['hardy'], variants=['alternate'])
584 Flavor('mythbuntu', variants=['desktop'])
585 Flavor('ubuntu-mid', variants=['usb'], archs=['lpia'])
586 Flavor('ubuntu-netbook', variants=['netbook', 'preinstalled'], archs=['i386', 'armel+omap', 'armel+omap4'])
587 Flavor('ubuntu-headless', variants=['preinstalled'], archs=['armel+omap', 'armel+omap4'])
588 Flavor('kubuntu-netbook', variants=['netbook'], archs=['i386'])
589 Flavor('kubuntu-mobile', variants=['mobile', 'preinstalled'], archs=['i386', 'armel+omap', 'armel+omap4'])
590 Flavor('ubuntu-moblin-remix', variants=['moblin-remix'], archs=['i386'])
591
592 default['variants'] = variantpaths.keys()
593 default['flavors'] = flavors.keys()
594
575 wanted['flavors'] = merge_config(config.flavor, file_cfg, default, 'flavors')595 wanted['flavors'] = merge_config(config.flavor, file_cfg, default, 'flavors')
576 if len(config.exclude_flavor) > 0:596 if len(config.exclude_flavor) > 0:
577 wanted['flavors'] = filter(lambda x: x not in config.exclude_flavor, wanted['flavors'])597 wanted['flavors'] = filter(lambda x: x not in config.exclude_flavor, wanted['flavors'])