Code review comment for lp:~jibel/livecd-rootfs/add_multi_layered_squashfses_support

Revision history for this message
Adam Conrad (adconrad) wrote :

I don't have time for a full review this morning, but unless we intend to keep these forked from the "real" ISOs for testing for a while, and then converge, I really don't like the SUBPROJECT use here. I'd expect the real 'ubuntu' project to be building these, not some ubuntu-random-subproject project.

As noted, you already can decide if you're building this type of image based on PASSES being defined, so it seems a bit odd to then also key on a subproject name.

« Back to merge proposal