Code review comment for lp:~jibel/autopilot/autopilot-sandbox-run

Revision history for this message
Martin Pitt (pitti) wrote :

Also, I don't immediately see anything which requires bash in the script, did I miss anything? It could be /bin/sh.

It's generally better to do

#!/bin/sh
set -eu

instead of "#!/bin/sh -eu"; with the latter, the -eu will be silently not happen if you run the script with e. g. "sh -x bin/autopilot-sandbox'run", but with the former the set -eu will always be considered.

« Back to merge proposal