Merge ~jhodapp/snappy-hwe-snaps/+git/alsa-utils:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/alsa-utils:master

Proposed by Jim Hodapp
Status: Merged
Approved by: Simon Fels
Approved revision: be5d971a16a6d39205554b42cf58b1ab84f7c791
Merged at revision: 2f58a78b5bc8b02054bf6ff8b8a0584e624f243d
Proposed branch: ~jhodapp/snappy-hwe-snaps/+git/alsa-utils:master
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/alsa-utils:master
Diff against target: 129 lines (+23/-35)
2 files modified
snapcraft.yaml (+17/-34)
tests/integration/lib/utilities.sh (+6/-1)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+323937@code.launchpad.net

Description of the change

Adopt for new aliases coming with snapd v2.25

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/snapcraft.yaml b/snapcraft.yaml
index e798d0c..ce7a5e8 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -17,88 +17,71 @@ apps:
17 speaker-test:17 speaker-test:
18 command: usr/bin/speaker-test18 command: usr/bin/speaker-test
19 plugs: [ alsa, home ]19 plugs: [ alsa, home ]
20 aliases:20 aliases: [speaker-test]
21 - speaker-test
22 alsactl:21 alsactl:
23 command: usr/sbin/alsactl22 command: usr/sbin/alsactl
24 plugs: [ alsa, home ]23 plugs: [ alsa, home ]
25 aliases:24 aliases: [alsactl]
26 - alsactl
27 amixer:25 amixer:
28 command: usr/bin/amixer26 command: usr/bin/amixer
29 plugs: [ alsa, home ]27 plugs: [ alsa, home ]
30 aliases:28 aliases: [amixer]
31 - amixer
32 aplay:29 aplay:
33 command: usr/bin/aplay30 command: usr/bin/aplay
34 plugs: [ alsa, home ]31 plugs: [ alsa, home ]
35 aliases:32 aliases: [aplay]
36 - aplay
37 aseqnet:33 aseqnet:
38 command: usr/bin/aseqnet34 command: usr/bin/aseqnet
39 plugs: [ alsa, home ]35 plugs: [ alsa, home ]
40 aliases:36 aliases: [aseqnet]
41 - aseqnet
42 alsatplg:37 alsatplg:
43 command: usr/bin/alsatplg38 command: usr/bin/alsatplg
44 plugs: [ alsa, home ]39 plugs: [ alsa, home ]
45 aliases:40 aliases: [alsatplg]
46 - alsatplg
47 arecordmidi:41 arecordmidi:
48 command: usr/bin/arecordmidi42 command: usr/bin/arecordmidi
49 plugs: [ alsa, home ]43 plugs: [ alsa, home ]
50 aliases:44 aliases: [arecordmidi]
51 - arecordmidi
52 amidi:45 amidi:
53 command: usr/bin/amidi46 command: usr/bin/amidi
54 plugs: [ alsa, home ]47 plugs: [ alsa, home ]
55 aliases:48 aliases: [amidi]
56 - amidi
57 alsaloop:49 alsaloop:
58 command: usr/bin/alsaloop50 command: usr/bin/alsaloop
59 plugs: [ alsa, home ]51 plugs: [ alsa, home ]
60 aliases:52 aliases: [alsaloop]
61 - alsaloop
62 alsaucm:53 alsaucm:
63 command: usr/bin/alsaucm54 command: usr/bin/alsaucm
64 plugs: [ alsa, home ]55 plugs: [ alsa, home ]
65 aliases:56 aliases: [alsaucm]
66 - alsaucm
67 aconnect:57 aconnect:
68 command: usr/bin/aconnect58 command: usr/bin/aconnect
69 plugs: [ alsa, home ]59 plugs: [ alsa, home ]
70 aliases:60 aliases: [aconnect]
71 - aconnect
72 iecset:61 iecset:
73 command: usr/bin/iecset62 command: usr/bin/iecset
74 plugs: [ alsa, home ]63 plugs: [ alsa, home ]
75 aliases:64 aliases: [iecset]
76 - iecset
77 alsabat:65 alsabat:
78 command: usr/bin/alsabat66 command: usr/bin/alsabat
79 plugs: [ alsa, home ]67 plugs: [ alsa, home ]
80 aliases:68 aliases: [alsabat]
81 - alsabat
82 aseqdump:69 aseqdump:
83 command: usr/bin/aseqdump70 command: usr/bin/aseqdump
84 plugs: [ alsa, home ]71 plugs: [ alsa, home ]
85 aliases:72 aliases: [aseqdump]
86 - aseqdump
87 aplaymidi:73 aplaymidi:
88 command: usr/bin/aplaymidi74 command: usr/bin/aplaymidi
89 plugs: [ alsa, home ]75 plugs: [ alsa, home ]
90 aliases:76 aliases: [aplaymidi]
91 - aplaymidi
92 alsamixer:77 alsamixer:
93 command: usr/bin/alsamixer78 command: usr/bin/alsamixer
94 plugs: [ alsa, home ]79 plugs: [ alsa, home ]
95 aliases:80 aliases: [alsamixer]
96 - alsamixer
97 arecord:81 arecord:
98 command: usr/bin/arecord82 command: usr/bin/arecord
99 plugs: [ alsa, home ]83 plugs: [ alsa, home ]
100 aliases:84 aliases: [arecord]
101 - arecord
10285
103plugs:86plugs:
104 device-conf:87 device-conf:
diff --git a/tests/integration/lib/utilities.sh b/tests/integration/lib/utilities.sh
index 1c89ef4..fc28747 100644
--- a/tests/integration/lib/utilities.sh
+++ b/tests/integration/lib/utilities.sh
@@ -32,8 +32,13 @@ install_snap_under_test() {
32 snap connect alsa-utils:$plug core32 snap connect alsa-utils:$plug core
33 done33 done
34 # Setup all necessary aliases34 # Setup all necessary aliases
35 snapd_version=$(snap version | awk '/^snapd / {print $2; exit}')
35 for alias in $SNAP_AUTO_ALIASES ; do36 for alias in $SNAP_AUTO_ALIASES ; do
36 snap alias $SNAP_NAME $alias37 target=$SNAP_NAME.$alias
38 if dpkg --compare-versions $snapd_version lt 2.25 ; then
39 target=$SNAP_NAME
40 fi
41 snap alias $target $alias
37 done42 done
38 fi43 fi
39}44}

Subscribers

People subscribed via source and target branches

to all changes: