Merge ~jfguedez/juju-lint:fix-unit-tests into juju-lint:master
Proposed by
Jose Guedez
Status: | Merged |
---|---|
Approved by: | James Troup |
Approved revision: | 4594e4175ff4aa5396ffa6bac49ce3295e5f828b |
Merged at revision: | 25a0f732a2268d9b950f7702f415f9f7ed3a78e4 |
Proposed branch: | ~jfguedez/juju-lint:fix-unit-tests |
Merge into: | juju-lint:master |
Diff against target: |
262 lines (+70/-23) 6 files modified
Makefile (+1/-1) jujulint/cli.py (+9/-1) jujulint/config.py (+1/-1) jujulint/lint.py (+54/-16) tests/conftest.py (+3/-2) tests/test_jujulint.py (+2/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Linda Guo (community) | Approve | ||
Juju Lint maintainers | Pending | ||
Review via email: mp+402958@code.launchpad.net |
Commit message
Fix current unit tests and formatting
To post a comment you must log in.
Fixes the current broken unit tests:
collected 4 items
tests/test_ cli.py: :test_pytest PASSED [ 25%] cli.py: :test_cli_ fixture PASSED [ 50%] jujulint. py::test_ flatten_ list PASSED [ 75%] jujulint. py::test_ map_charms PASSED [100%]
tests/test_
tests/test_
tests/test_
------- ------- ------- ------- ---- generated xml file: /home/jguedez/ canonical/ repos/bootstack /juju-lint/ tests/report/ junit.xml ------- ------- ------- ------- ---- ------- ------- ------ generated html file: file:// /home/jguedez/ canonical/ repos/bootstack /juju-lint/ tests/report/ index.html ------- ------- ------- -------
-------
----------- coverage: platform linux, python 3.8.5-final-0 ----------- ------- ------- ------- ------- ------- - __init_ _.py 0 0 100% openstack. py 14 5 64% ------- ------- ------- ------- ------- - coverage- annotated coverage- html
Name Stmts Miss Cover
-------
jujulint/
jujulint/cli.py 79 54 32%
jujulint/cloud.py 170 150 12%
jujulint/config.py 17 0 100%
jujulint/k8s.py 13 13 0%
jujulint/lint.py 388 331 15%
jujulint/logging.py 49 26 47%
jujulint/
jujulint/util.py 20 3 85%
-------
TOTAL 750 582 22%
Coverage annotated source written to dir tests/report/
Coverage HTML written to dir tests/report/
======= ======= ======= ======= ======= ======= ======= ======= ======= ====== 4 passed in 0.65s ======= ======= ======= ======= ======= ======= ======= ======= ======= ======= _______ _______ _______ _______ _______ _______ _______ _______ _______ ____ summary _______ _______ _______ _______ _______ _______ _______ _______ _______ _______ _____
_______
unit: commands succeeded
congratulations :)