Code review comment for lp:~jerico-dev/rhythmbox/rb-ipod-support-video-podcast

Revision history for this message
jerico (jerico-dev) wrote :

Hi Robert, this patch introduces the new field RHYTHMDB_PROP_HAS_VIDEO. I had a quick email exchange with upstream maintainer Jonathan Matthew about the patch. He thinks that yes, there might be upgrade problems. He says: "This feature involves some changes that we need to be very careful with, so we really need to do this upstream first." And I agree with him.

Jonathan promised to get back to me with a more detailed review of the patch at the time I submitted the merge request. But I guess he didn't have time yet. BTW: It seems I'm not the only one interested in this change coming out: https://bugzilla.gnome.org/show_bug.cgi?id=363822.

« Back to merge proposal