Code review comment for lp:~jeremywootten/slingshot/fix-1213321

Did you want asterisks on each line? Your original suggestion did not have
them but this one does.

I agree that thorough testing by others first is advisable.

On 4 September 2013 13:27, David Gomes <email address hidden> wrote:

> Review: Needs Fixing
>
> + /*Overriding the default handler results in infinite loop of error
> messages
> + * when an input method is in use (Gtk3 bug?). Key press events are
> + * captured by an Event Box and passed to this function instead.
> + * Events not dealt with here are propagated to the searchbar by the
> + * usual mechanism.
> + */
>
> + /*
> + * Overriding the default handler results in infinite loop of error
> messages
> + * when an input method is in use (Gtk3 bug?). Key press events are
> + * captured by an Event Box and passed to this function instead.
> +
> + * Events not dealt with here are propagated to the searchbar by the
> + * usual mechanism.
> + */
>
> I'd prefer that and then I approve. Besides, I don't want this merged
> without testing (both on people experiencing the bug and people who don't
> use ibus and never experienced the bug).
> --
>
> https://code.launchpad.net/~jeremywootten/slingshot/fix-1213321/+merge/182058
> You are the owner of lp:~jeremywootten/slingshot/fix-1213321.
>

--
Jeremy Wootten
GPG Key ID CB585BCD
Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD