Merge lp:~jeremywootten/screenshot-tool/fix-1438250-include-child-windows into lp:~elementary-apps/screenshot-tool/trunk
Status: | Superseded |
---|---|
Proposed branch: | lp:~jeremywootten/screenshot-tool/fix-1438250-include-child-windows |
Merge into: | lp:~elementary-apps/screenshot-tool/trunk |
Diff against target: |
427 lines (+284/-53) 1 file modified
src/ScreenshotWindow.vala (+284/-53) |
To merge this branch: | bzr merge lp:~jeremywootten/screenshot-tool/fix-1438250-include-child-windows |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergey Kislyakov (community) | Needs Fixing | ||
elementary Apps team | Pending | ||
Review via email:
|
This proposal has been superseded by a proposal from 2017-04-08.
Description of the change
This branch provides a solution to the problem of including popups and menus in a snapshot of a current window. Instead of using pixbuf_
This is complicated by the fact that window.
It is recognised that this solution is "hacky" so if a simpler solution is available it should be preferred.
If the current window is partially off the current screen the the grabbed screenshot will be truncated - unlike in the trunk. Any menus or popups extending outside the main window will also be truncated.
While rewriting grab_save (), the method of capturing the cursor position was changed in order to place it more accurately. (lp:1627704)
In addition, due to problems experienced during development where the program crashed while system text was redacted, code was included that recovered the normal text when the program was run again.
Unmerged revisions
- 319. By Jeremy Wootten
-
Composite using Cairo
- 318. By Jeremy Wootten
-
Merge trunk to r318 and resolve conflict
- 317. By Jeremy Wootten
-
Fix detect shadow; composite shadow in screenshot
- 316. By Jeremy Wootten
-
Fix placement of cursor
- 315. By Jeremy Wootten
-
Include popups and menus in current window snapshot; Recover from redacted system after crash
You can't capture the Terminal window anymore - it crashes with segfault.