Screenshot

lp:~jeremywootten/screenshot-tool/fix-1438250-include-child-windows

Created by Jeremy Wootten on 2017-03-20 and last modified on 2017-04-08

This branch provides a solution to the problem of including popups and menus in a snapshot of a current window. Instead of using pixbuf_get_from_window, the same method as used for grabbing selected areas is used - that is obtaining a subpixbuf from the whole window - after calculating a suitable selection rectangle.

This is complicated by the fact that window.get_frame_extents includes any border around the main window area used to show shadows etc. The function that discounts this relies on it having a low opacity compared with the rest of the window. The method therefore relies on the pixbufs obtained will have four channels per pixel with one byte per channel. It is not known whether changing to Wayland will affect this.

If the current window is partially off the current screen the the grabbed screenshot will be truncated - unlike in the trunk.

In addition, due to problems experienced during development where the program crashed while system text was redacted, code was included that recovered the normal text when the program was run again.

Get this branch:: bzr branch lp:~jeremywootten/screenshot-tool/fix-1438250-include-child-windows

Only Jeremy Wootten can upload to this branch. If you are Jeremy Wootten please log in for upload directions.

Branch merges

No branches dependent on this one.

On hold for merging into lp:~elementary-apps/screenshot-tool/trunk

Danielle Foré: Needs Fixing on 2017-04-18

Sergey Kislyakov (community): Approve on 2017-04-09

Related bugs

Bug #1438250: "Current window" doesn't include children like popovers	High	In Progress
Bug #1627704: mouse position shows in upper-left corner when taking a custom area screenshot	Low	In Progress
Bug #1678520: "Screenshot current window" of non-CSD window doesn't include decoration	Medium	In Progress

Link a bug report

Related blueprints

Branch information

Owner:: Jeremy Wootten

Project:: Screenshot

Status:: Abandoned

Recent revisions

319. By Jeremy Wootten on 2017-04-08: Composite using Cairo
318. By Jeremy Wootten on 2017-04-06: Merge trunk to r318 and resolve conflict
317. By Jeremy Wootten on 2017-04-06: Fix detect shadow; composite shadow in screenshot
316. By Jeremy Wootten on 2017-03-23: Fix placement of cursor
315. By Jeremy Wootten on 2017-03-21: Include popups and menus in current window snapshot; Recover from redacted system after crash
314. By Launchpad Translations on behalf of elementary-apps on 2017-03-19: Launchpad automatic translations update.
313. By Launchpad Translations on behalf of elementary-apps on 2017-03-14: Launchpad automatic translations update.
312. By Launchpad Translations on behalf of elementary-apps on 2017-03-05: Launchpad automatic translations update.
311. By Launchpad Translations on behalf of elementary-apps on 2017-03-03: Launchpad automatic translations update.
310. By Launchpad Translations on behalf of elementary-apps on 2017-03-02: Launchpad automatic translations update.

Branch metadata

Branch format:: Branch format 7

Repository format:: Bazaar repository format 2a (needs bzr 1.16 or later)

Stacked on:: lp:~elementary-apps/screenshot-tool/trunk

This branch contains Public information

Everyone can see this information.

Subscribers

Jeremy Wootten