Code review comment for lp:~jeremywootten/pantheon-files/fix-network-browsing

Revision history for this message
PerfectCarl (name-is-carl) wrote :

# Test with a SMB share from a luna VM (samba = 2:3.6.3-2ubuntu2.11)

40) the first time I connect to the SMB domain, all the shares are displayed with a red cross.
What is the meaning of the cross?
http://i.imgur.com/EmDkwJw.png

41) Not sure if that's a bug or a feature but when two windows are opened to the same shared folder, any operation done to one window is not synchronized to the other one.
Unlike how it is done to local folders.
Please confirm that this is done on purpose.

(Unmounting the share refreshes both windows though - neat!)

42) when the mouse moves over the samba icon in the sidebar, there is a fuzzy effect on the icon
https://ele.slack.com/files/carl/F039M70J0/files-network-icons.webm
Is this intended?

43) when displaying the property dialog for a shared folder, the free/total space of the current local partition is displayed.
Either display the remote free/total space of the remote share (if available) or either hide the bar

44) question: shouldn't be the tab named 'private' instead of '/' ?
http://i.imgur.com/laMnyGh.png

45) Can't create an archive in a folder where I can create files in.
Not sure if file-roller is to blame here or Files, but that's annoying.
(Same error with Nautilus though so I would say file-roller)

46) Create a shortcut to a file present on a share folder in the sidebar.
Unmount the share.
Click on the shorcut: you will be said that the file doesn't exist.
If you click on the file one more time, the file will become available.

« Back to merge proposal