Files

Code review comment for lp:~jeremywootten/pantheon-files/fix-network-browsing

  1. fix-network-browsing
  2. Merge into trunk
Revision history for this message
PerfectCarl (name-is-carl) wrote :

Hello,

All in all, it feels more stable and faster.
Congratulations!

I haven't tested everything yet but here's my feedback

26, 27, 28 are fixed (nice!)

22 is fixed
23 I added an issue for contractor : https://bugs.launchpad.net/elementaryos/+bug/1405878

30) I still have the following critical warnings:
[_LOG_LEVEL_FATAL 23:16:12.363828] gof_file_is_mountable: assertion 'file->info != NULL' failed
[_LOG_LEVEL_FATAL 23:16:12.363878] Files will not function properly.

31) is it expected that the permission tab in the properties dialog is not shown for files in SAMBA share whether I have read/write permissions or not?

32) is it on purpose that I can't add a samba server (\\CRAN-VIRTUALBOX) or even a samba share (\\CRAN-VIRTUALBOX\share) but only a folder (\\CRAN-VIRTUALBOX\share\folder) to the bookmark?
I find adding at a samba share useful.

« Back to merge proposal