Code review comment for lp:~jeremywootten/pantheon-files/fix-network-browsing

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Thanks again Carl for your thorough testing!

20) Mount button truncation also occurs in trunk and is a bug in the sidebar, so will need a separate bug report.
21) I will set the mount_mountable warnings to "debug" so that will not normally appear.
22, 23 & 28) I will try to improve the relevance of the context menus. Its a trickier with network locations. The appearance of inappropriate plugin/contractor entries like "Compress" may have to be dealt with in the plugins/contractors themselves.
24, 25) These are issues with connect server dialog and outside the scope of this branch - I suggest they are added to your networking blueprint. It appears that Samba lets you connect to a public share using any credentials. Each connection with a different set of credentials appears as another entry in the sidebar but you can only distinguish them by looking at the tooltip. I haven't investigated whether there are any problems having multiple connections like this.
26, 27, 28, 29) I can confirm these (except for the segfault) but haven't found the reason yet.

« Back to merge proposal