Code review comment for lp:~jeremywootten/pantheon-files/fix-network-browsing

Revision history for this message
PerfectCarl (name-is-carl) wrote :

1) Should we not restore network folders?
Well I don't know if the network folders should be restored mounted or un-mounted (I would vote for un-mounted though - as it is the case for other drives).

What ever the solution, restoring network folders must be done more asynchronously not to stop the UI thread.

4) Do we need "Properties" dialog for network locations?
Yes very much so.
One because those information are entered by the user. Not offering a way to edit them is akin to data loss to me (not a catastrophic one, I agree).
Second because once I'm connected to the server, there is no way to check what I'm connected to - or how. Suppose I don't remember which server (or user) I entered, I'm stuck.

Again I'm not sure that this is in the scope of this merge proposal but this is very important to make network folders actually usable.

« Back to merge proposal