Code review comment for lp:~jeremywootten/pantheon-files/fix-network-browsing

Revision history for this message
PerfectCarl (name-is-carl) wrote :

I totally agree with you about keeping the scope tight.

I did report everything that I noticed so I can have your opinion about "bug" or "out of scope".
Not that I have your feedback, I filed the following reports.

3) This is outside the scope of the branch -and also happens on other File Managers (Thunar, Nautilus). Do we need "Properties" dialog for network locations?
-> https://bugs.launchpad.net/pantheon-files/+bug/1400731

6) and 7) and 8) Server connection dialog is outside scope of branch
-> https://bugs.launchpad.net/pantheon-files/+bug/1400735
-> https://bugs.launchpad.net/pantheon-files/+bug/1400738
-> https://bugs.launchpad.net/pantheon-files/+bug/1400740

14) Do you mean servers are not remembered in the "Connect to Server" dialog? This is outside the scope of the branch
-> https://bugs.launchpad.net/pantheon-files/+bug/1400734

All those issues can be found there : https://bugs.launchpad.net/pantheon-files/+bugs?field.tag=networking
(two older issues are not mine)

« Back to merge proposal