Files

Code review comment for lp:~jeremywootten/pantheon-files/fix-network-browsing

fix-network-browsing
Merge into trunk

Revision history for this message

PerfectCarl (name-is-carl) wrote on 2014-12-08:

4) The "Windows network" has a property windows that let the user change the permission (chmod) of the item. Is this really useful/taken into account?

5) The right click menu of "Windows network" shows a "open in terminal" that does nothing (the terminal app is opened though)

6) The error message is not very helpful "invalid argument is very vague"
http://i.imgur.com/9BX6AAE.png

7) Put sample text in the field to help the user to fill out the form. At the moment empty fields are not very helpful.
http://i.imgur.com/SVMLJ3g.png
I would recommend :
  - server: 12.34.56.78
  - folder: nothing
  - Domain name: WORKGROUP

8) The port field must be hidden if it can't be used

9) I have a samba server on my local network but I haven't configured it in Files. Viewing the "Windows server" causes the application to be irresponsive.
The console displays this:
[_LOG_LEVEL_FATAL 14:33:06.441194] [GLib-GIO] g_file_info_get_attribute_string: assertion 'G_IS_FILE_INFO (info)' failed
[_LOG_LEVEL_FATAL 14:33:06.441324] Files will not function properly.
[_LOG_LEVEL_FATAL 14:33:12.247325] [GLib-GIO] g_app_info_get_all_for_type: assertion 'content_type != NULL' failed
[_LOG_LEVEL_FATAL 14:33:12.247420] Files will not function properly.
[_LOG_LEVEL_WARN 14:33:12.255183] plugin.vala:96: GDBus.Error:org.elementary.ContractorError.NoMimetypesGiven: No mimetypes were provided.
[_LOG_LEVEL_FATAL 14:33:14.680825] [GLib-GIO] g_file_info_get_attribute_string: assertion 'G_IS_FILE_INFO (info)' failed
[_LOG_LEVEL_FATAL 14:33:14.680882] Files will not function properly.
[_LOG_LEVEL_WARN 14:33:48.733310] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted
[_LOG_LEVEL_WARN 14:34:07.293536] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted
[_LOG_LEVEL_WARN 14:34:07.293807] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted

After some time, files displays "network://smb:0/" which is empty
Going from a tab displaying local data to "network://smb:0/" is also slow.

10) Failing to connect to the server because of invalid details give one error message "Failed to mount Windows share". If I click to "continue" without changing anything, I get another message "Please verify your user details"
http://i.imgur.com/2sopzoJ.png
http://i.imgur.com/y16DOEH.png
Note that the button label is changing. Not sure that this is a good idea

4) The "Windows network" has a property windows that let the user change the permission (chmod) of the item. Is this really useful/taken into account?

5) The right click menu of "Windows network" shows a "open in terminal" that does nothing (the terminal app is opened though)

6) The error message is not very helpful "invalid argument is very vague" 
http://i.imgur.com/9BX6AAE.png

7) Put sample text in the field to help the user to fill out the form. At the moment empty fields are not very helpful.
http://i.imgur.com/SVMLJ3g.png
I would recommend : 
  - server: 12.34.56.78
  - folder: nothing
  - Domain name: WORKGROUP

8) The port field must be hidden if it can't be used

9) I have a samba server on my local network but I haven't configured it in Files. Viewing the "Windows server" causes the application to be irresponsive.
The console displays this: 
[_LOG_LEVEL_FATAL 14:33:06.441194] [GLib-GIO] g_file_info_get_attribute_string: assertion 'G_IS_FILE_INFO (info)' failed
[_LOG_LEVEL_FATAL 14:33:06.441324] Files will not function properly.
[_LOG_LEVEL_FATAL 14:33:12.247325] [GLib-GIO] g_app_info_get_all_for_type: assertion 'content_type != NULL' failed
[_LOG_LEVEL_FATAL 14:33:12.247420] Files will not function properly.
[_LOG_LEVEL_WARN 14:33:12.255183] plugin.vala:96: GDBus.Error:org.elementary.ContractorError.NoMimetypesGiven: No mimetypes were provided.
[_LOG_LEVEL_FATAL 14:33:14.680825] [GLib-GIO] g_file_info_get_attribute_string: assertion 'G_IS_FILE_INFO (info)' failed
[_LOG_LEVEL_FATAL 14:33:14.680882] Files will not function properly.
[_LOG_LEVEL_WARN 14:33:48.733310] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted
[_LOG_LEVEL_WARN 14:34:07.293536] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted
[_LOG_LEVEL_WARN 14:34:07.293807] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted

After some time, files displays "network://smb:0/" which is empty
Going from a tab displaying local data to "network://smb:0/" is also slow.

10) Failing to connect to the server because of invalid details give one error message "Failed to mount Windows share". If I click to "continue" without changing anything, I get another message "Please verify your user details"
http://i.imgur.com/2sopzoJ.png
http://i.imgur.com/y16DOEH.png
   Note that the button label is changing. Not sure that this is a good idea

« Back to merge proposal