Code review comment for lp:~jeremywootten/pantheon-files/fix-network-browsing

Revision history for this message
PerfectCarl (name-is-carl) wrote :

Here are my remarks.

1) when files starts displaying network (because it was the last folder opened in the last session) it slows down the startup even if no network can be found
  Also it logs the following in the console:
[_LOG_LEVEL_WARN 13:55:55.176021] Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-c9DXGlcvF5: Connection refused

2) When I double click on Windows Network with no server, this is written to the console:
[_LOG_LEVEL_FATAL 14:03:35.490005] [GLib-GIO] g_file_info_get_attribute_string: assertion 'G_IS_FILE_INFO (info)' failed
[_LOG_LEVEL_FATAL 14:03:35.490060] Files will not function properly.
[_LOG_LEVEL_WARN 14:03:38.563686] gof-directory-async.vala:99: mount_mountable failed: Failed to retrieve share list from server: No such file or directory
[_LOG_LEVEL_WARN 14:03:38.579646] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted
[_LOG_LEVEL_FATAL 14:03:38.692921] [GLib-GIO] g_file_info_get_attribute_string: assertion 'G_IS_FILE_INFO (info)' failed
[_LOG_LEVEL_FATAL 14:03:38.693035] Files will not function properly.
[_LOG_LEVEL_WARN 14:03:38.715301] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted
[_LOG_LEVEL_WARN 14:03:38.716851] ZeitgeistManager.vala:15: Fetching file info folder loggin to zeitgeist failed: The specified location is not mounted
[_LOG_LEVEL_FATAL 14:03:47.079300] [GLib-GIO] g_file_info_get_attribute_string: assertion 'G_IS_FILE_INFO (info)' failed
[_LOG_LEVEL_FATAL 14:03:47.079349] Files will not function properly.

3) The size of Windows Network is 0 bytes when there is no sever. Shouldn't it be left blank or named "0 server"?
http://i.imgur.com/zXgD1Fn.png

« Back to merge proposal