Code review comment for lp:~jeremywootten/pantheon-files/fix-1631982-run-as-admin-warning

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Dieter: Thanks for the review. The reason a local variable is assigned to the Files[] parameter in a couple of places is so that it can be used in the following closure. However, I have changed the code a little so that an empty array is used when there are no commandline parameters as this feels better than using a null and fixes conflicting types.

I have also fixed the indentation and updated the branch so that it does not conflict with current trunk.

There seems to be a problem using commandline parameters with pantheon-files-pkexec anyway - they are not being passed to the application or are ignored at some point. I need to fix this as it does not occur in trunk. Putting back to "In progress" for now.

« Back to merge proposal