Code review comment for lp:~jeremywootten/pantheon-files/fix-1592068-viewmode-buttons-do-not-update
Revision history for this message
| Adam Bieńkowski (donadigo) wrote | # |
review:
Needs Fixing
(code / testing)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
I can confirm that this is much more cleaner solution and it fixes the problems with navigation buttons and view mode switcher as well.
Only one thing: update_view_method is no longer needed as this is done already in update_top_menu, even the compiler points this out, we should remove it.