Merge lp:~jeremywootten/pantheon-files/fix-1465155-crash-on-toggle-hiddens-in-list-view into lp:~elementary-apps/pantheon-files/trunk

[Jeremy Wootten]

Remove subdirectories, not reload them, when toggling show-hidden-files in List view (lp:1465155)

Fixes crash caused by attempting to reload subdirectories after model was cleared when toggling show-hidden-files. Also empties loaded subdirectory list before toggling to prevent reference leak.

=== modified file 'src/View/AbstractDirectoryView.vala'
--- src/View/AbstractDirectoryView.vala	2015-06-06 08:41:29 +0000
+++ src/View/AbstractDirectoryView.vala	2015-06-15 08:45:30 +0000
@@ -1221,16 +1221,13 @@
     /** Handle Preference changes */
         private void on_show_hidden_files_changed (GLib.Object prefs, GLib.ParamSpec pspec) {
             bool show = (prefs as GOF.Preferences).show_hidden_files;
+            cancel ();
             if (!show) {
                 block_model ();
                 model.clear ();
             }
 
             directory_hidden_changed (slot.directory, show);
-            if (loaded_subdirectories != null)
-                loaded_subdirectories.@foreach ((dir) => {
-                    directory_hidden_changed (dir, show);
-                });
 
             if (!show)
                 unblock_model ();