Code review comment for lp:~jeremywootten/pantheon-files/fix-1196427

OK, thanks for the advice!

On 25 November 2013 16:35, Victor Martinez <email address hidden> wrote:

> Good observation.
>
> I'm pretty sure it was defined as "const char*" because it was an unowned
> string, so nobody else should free it.
>
> Since the bookmark it taking its own copy now, the "const" should be
> removed from the definition. It should be just "char *name". Then free it
> with g_free.
>
> See
> https://developer.gnome.org/glib/2.36/glib-String-Utility-Functions.html#g-strdup
> --
>
> https://code.launchpad.net/~jeremywootten/pantheon-files/fix-1196427/+merge/195513
> You are the owner of lp:~jeremywootten/pantheon-files/fix-1196427.
>

--
Jeremy Wootten
GPG Key ID CB585BCD
Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD