Thanks. Not sure where the extra parentheses came from, now - I'll remove. Diff line 17 was for testing and can be removed. I await the results of your testing with interest.
On 15 January 2014 01:31, David Gomes <email address hidden> wrote:
> Review: Needs Fixing > > >return (g_list_length (manager->files)); > Wouldn't just > >return g_list_length (manager->files); > be better? In terms of code style of course. > > Also, diff line 17 doesn't seem to be working. > > Other than that, I approve of it, I'll just have to test it. > -- > > https://code.launchpad.net/~jeremywootten/pantheon-files/fix-1028637/+merge/201174 > You are the owner of lp:~jeremywootten/pantheon-files/fix-1028637. >
-- Jeremy Wootten GPG Key ID CB585BCD Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD
« Back to merge proposal
Thanks. Not sure where the extra parentheses came from, now - I'll remove.
Diff line 17 was for testing and can be removed. I await the results of
your testing with interest.
On 15 January 2014 01:31, David Gomes <email address hidden> wrote:
> Review: Needs Fixing /code.launchpad .net/~jeremywoo tten/pantheon- files/fix- 1028637/ +merge/ 201174
>
> >return (g_list_length (manager->files));
> Wouldn't just
> >return g_list_length (manager->files);
> be better? In terms of code style of course.
>
> Also, diff line 17 doesn't seem to be working.
>
> Other than that, I approve of it, I'll just have to test it.
> --
>
> https:/
> You are the owner of lp:~jeremywootten/pantheon-files/fix-1028637.
>
--
Jeremy Wootten
GPG Key ID CB585BCD
Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD