Code review comment for lp:~jeremywootten/pantheon-files/connect-server-plugin-in-sidebar

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

> "Connect server" should be "Connect to Server"
>
> I think a better icon might be "network-server" or "network-workgroup"
>
> Also Cody's screenshot shows that there has been some kind of theme issue
> introduced. The widget no longer expands to fill the height of the pane

OK, I have fixed these issues, using the "network-server" icon. Note that the "network-server" and "network-workgroup" icons appear the same as the one already used for "Entire Network" item (on my system).

Instead of the string "network-server", Marlin.ICON_NETWORK_SERVER should really have been used (defined in /src/View/Resources.vala) but I need the advice of a cmake expert how to make this visible to /plugins/network-places/plugin.vala

review: Needs Resubmitting

« Back to merge proposal