Code review comment for lp:~jeremychang/linaro-image-tools/android-boottarball

Revision history for this message
Jeremy Chang (jeremychang) wrote :

Hi, Alexander:
    I fixed the umount error. Thanks for the feedback.

Hi, James:
    Thanks for your review and suggestion. I improved the code to
share more in between and pushed.
    If there's more could be better or comments, please let me know.

Thanks,
--
-Jeremy

On Fri, Apr 22, 2011 at 7:03 PM, Alexander Sack <email address hidden> wrote:
> --dev panda spits out a warning after formatting, but seems to work.
>
> This filesystem will be automatically checked every 23 mounts or
> 180 days, whichever comes first.  Use tune2fs -c or -i to override.
> mkfs.vfat 3.0.9 (31 Jan 2010)
> Image Name:   boot script
> Created:      Fri Apr 22 12:23:05 2011
> Image Type:   ARM Linux Script (uncompressed)
> Data Size:    330 Bytes = 0.32 kB = 0.00 MB
> Load Address: 00000000
> Entry Point:  00000000
> Contents:
>   Image 0: 322 Bytes = 0.31 kB = 0.00 MB
> umount: /tmp/tmpESyiEo/boot-disc: device is busy.
>        (In some cases useful info about processes that use
>         the device is found by lsof(8) or fuser(1))
> --
> https://code.launchpad.net/~jeremychang/linaro-image-tools/android-boottarball/+merge/58545
> You are the owner of lp:~jeremychang/linaro-image-tools/android-boottarball.
>

« Back to merge proposal