Code review comment for lp:~jeremy-munsch/synapse-project/native-de-shortcut

Revision history for this message
Jérémy Munsch (jeremy-munsch) wrote :

Ok thank you, I applied the patch.

> Jfyi, regarding "space_index = -1 == space_index ? 0 : space_index+1;". You
> can't simply do "space_index+1" since this might not be a valid byte-position
> in this utf8 string.

Indeed I haven't taught about that.

« Back to merge proposal