Code review comment for lp:~jeremy-munsch/synapse-project/desktop-file-actions

Revision history for this message
Jérémy Munsch (jeremy-munsch) wrote :

Ok, i understand your point, though it would have been more readable.
So i updated from your patch made a small fix, and added tranlations by using GLib.DesktopAppInfo.get_action_name.

As for
  /* If there's more than one application, fill the ow list */
  if (list_for_mimetype.size > 1)

I removed it because, whitout your recommendations, i felt like it was non sense to not display the option for the only program that can open the file type. But, yes, i should not have done that. It is just hard to not touch things when you fell it could be improved, never mind though.

« Back to merge proposal