Code review comment for lp:~jeremy-munsch/synapse-project/desktop-file-actions

Revision history for this message
Jérémy Munsch (jeremy-munsch) wrote :

As for GLib, the bump would only leave precise (12.04LTS) unsupported since it is distributed with GLib 2.32.4. I only check Ubuntu because i believe the edge ppa of synapse has only releases to this distribution.

I used no code of the related commit, I originally linked the bug because that is the reason i made this fix and i got a mail notice of the bug.

I make my contributions on Synapse mostly by mimicking the original code for doing what i want since i'm definitely not a Vala expert. But i'll make sure if i use another code to make appropriate link to the original author.

Thank you for the devhelp tip, i'll use this from now :)

So what i'm going to fix are:
coding style for things I'have changed
cleaning find_for_match code

« Back to merge proposal