Code review comment for lp:~jelmer/wikkid/null-revision

Revision history for this message
Tim Penhey (thumper) wrote :

Hi Jelmer,

This makes the test suite fail:

ERROR: wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file
----------------------------------------------------------------------
Text attachment: log
------------
1.631 creating repository in file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/.
1.634 creating branch <bzrlib.branch.BzrBranchFormat7 object at 0x39c7090> in file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/
1.640 trying to create missing lock '/tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/dirstate'
1.640 opening working tree '/tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work'
1.645 skip control directory '.bzr'
1.645 creating config directory: '/tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/home/.bazaar'
1.648 preparing to commit
    INFO Committing to: /tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/
1.650 Selecting files for commit with filter None
    INFO added README
    INFO Committed revision 1.
1.668 opening working tree '/tmp/testbzr-lrpIxX.tmp'
------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 153, in _runCleanups
    function(*arguments, **keywordArguments)
AssertionError: Different number of acquired and released or broken locks. ([LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/branch-lock3wtt4kz8cx40cwolrim4), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/repository/locks1n7dza8ncd6g4mpkm3n), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/branch/lock00a4oh1pyoqalyn1ojjt), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/lock5i05vu2exlsh0iz13bvd), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/lock71m26fqbpszpruhrzqcj), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/branch/lockkai5puavhgt9w3n950aj), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/lockvho3y2u6zp2rk7u51gm6), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/repository/lock452dh8q3ts2rdxjdagmh), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/branch/lockhhtjr77jxj86io359ii9), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/lockp7q43swcrowzce5ftw08)], [LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/branch-lock3wtt4kz8cx40cwolrim4), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/repository/locks1n7dza8ncd6g4mpkm3n), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/branch/lock00a4oh1pyoqalyn1ojjt), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/lock5i05vu2exlsh0iz13bvd), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/lock71m26fqbpszpruhrzqcj), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/repository/lock452dh8q3ts2rdxjdagmh), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/checkout/lockvho3y2u6zp2rk7u51gm6), LockResult(file:///tmp/testbzr-lrpIxX.tmp/wikkid.tests.test_bzr_filestore.TestBzrFileStore.test_updating_existing_file/work/.bzr/branch/lockkai5puavhgt9w3n950aj)] + [])
------------

review: Needs Fixing

« Back to merge proposal