Code review comment for lp:~jelmer/meliae/itervalues

Revision history for this message
John A Meinel (jameinel) wrote :

It seems our Python 3 support isn't quite as complete as we thought:
https://bugs.launchpad.net/meliae/+bug/1883514

The test isn't very robust but just calling dump_gc_objects triggers fatal errors:
+ def test_smoke_dump_gc_objects(self):
+ a_dict = {'some_specialty_content': 'more_content'}
+ t = tempfile.TemporaryFile(prefix='meliae-')
+ t_file = getattr(t, 'file', t)
+ scanner.dump_gc_objects(t_file)
+ t.flush()
+ t.seek(0)
+ content = t_file.read()
+ self.assertIn('some_specialty_content', content)
+

« Back to merge proposal