Couple of nitpicks, nothing major:
[1]
104 + def test_missing_revision(self):
109 + def test_some(self):
122 + def test_children(self):
These all need leading comments or docstrings explaining the expected behaviour for which they're testing, e.g.:
def test_foo_bars(self): """When called, foo() returns bar.""" ...
[2]
109 + def test_some(self): 110 + branch = self.make_branch('test') 111 + wt = branch.bzrdir.create_workingtree() 112 + wt.commit('msg a', rev_id='A') 113 + wt.commit('msg b', rev_id='B') 114 + wt.commit('msg c', rev_id='C') 115 + self.assertEqual( 116 + set(['A']), get_ancestry(branch.repository, 'A')) 117 + self.assertEqual( 118 + set(['A', 'B']), get_ancestry(branch.repository, 'B')) 119 + self.assertEqual( 120 + set(['A', 'B', 'C']), get_ancestry(branch.repository, 'C'))
s/wt/tree (or something meaningful). Same thing in test_children().
« Back to merge proposal
Couple of nitpicks, nothing major:
[1]
104 + def test_missing_ revision( self):
109 + def test_some(self):
122 + def test_children( self):
These all need leading comments or docstrings explaining the expected
behaviour for which they're testing, e.g.:
def test_foo_ bars(self) :
"""When called, foo() returns bar."""
...
[2]
109 + def test_some(self): branch( 'test') bzrdir. create_ workingtree( ) branch. repository, 'A')) branch. repository, 'B')) branch. repository, 'C'))
110 + branch = self.make_
111 + wt = branch.
112 + wt.commit('msg a', rev_id='A')
113 + wt.commit('msg b', rev_id='B')
114 + wt.commit('msg c', rev_id='C')
115 + self.assertEqual(
116 + set(['A']), get_ancestry(
117 + self.assertEqual(
118 + set(['A', 'B']), get_ancestry(
119 + self.assertEqual(
120 + set(['A', 'B', 'C']), get_ancestry(
s/wt/tree (or something meaningful). Same thing in test_children().