Code review comment for lp:~jelmer/launchpad/no-revhistory-3

Revision history for this message
Graham Binns (gmb) wrote :

Couple of nitpicks, nothing major:

[1]

104 + def test_missing_revision(self):

109 + def test_some(self):

122 + def test_children(self):

These all need leading comments or docstrings explaining the expected
behaviour for which they're testing, e.g.:

 def test_foo_bars(self):
    """When called, foo() returns bar."""
    ...

[2]

109 + def test_some(self):
110 + branch = self.make_branch('test')
111 + wt = branch.bzrdir.create_workingtree()
112 + wt.commit('msg a', rev_id='A')
113 + wt.commit('msg b', rev_id='B')
114 + wt.commit('msg c', rev_id='C')
115 + self.assertEqual(
116 + set(['A']), get_ancestry(branch.repository, 'A'))
117 + self.assertEqual(
118 + set(['A', 'B']), get_ancestry(branch.repository, 'B'))
119 + self.assertEqual(
120 + set(['A', 'B', 'C']), get_ancestry(branch.repository, 'C'))

s/wt/tree (or something meaningful). Same thing in test_children().

review: Approve (code)

« Back to merge proposal