Code review comment for lp:~jelmer/launchpad/bzr-code-imports

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

> This (finally!) looks fine to me. Thanks for plugging away. Maybe a positive
> test for a branch reference being imported would be nice?
I'll add one.

> BzrServer._use_server appears to always be false, so maybe some code can be
> deleted?
I'd like to keep it around for the moment. Hopefully we can switch to running actual VCS servers at some point, so we can use the proper database constrains for code import URLs.

Thanks for all your reviews :)

« Back to merge proposal