This branch looks good to me.
Regarding the lint that Ian mentioned, here's a lint report that shows the problems:
./lib/lp/app/widgets/doc/launchpad-radio-widget.txt 1: narrative uses a moin header. 38: narrative uses a moin header. ./lib/lp/code/browser/codeimport.py 361: Line exceeds 78 characters. 270: E261 at least two spaces before inline comment 280: E261 at least two spaces before inline comment 361: E501 line too long (81 characters) ./lib/lp/code/stories/branches/xx-junk-branches.txt 33: narrative exceeds 78 characters. ./lib/lp/code/stories/codeimport/xx-create-codeimport.txt 43: source exceeds 78 characters. ./lib/lp/registry/browser/tests/productseries-setbranch-view.txt 98: source exceeds 78 characters. 115: source exceeds 78 characters. 137: source exceeds 78 characters. 144: want exceeds 78 characters. 164: source exceeds 78 characters. 184: source exceeds 78 characters. 189: want exceeds 78 characters. 203: source exceeds 78 characters. 223: source exceeds 78 characters. 243: source exceeds 78 characters. 263: source exceeds 78 characters. 283: source exceeds 78 characters. 304: source exceeds 78 characters. 370: want exceeds 78 characters. 388: want exceeds 78 characters. 408: source exceeds 78 characters.
« Back to merge proposal
This branch looks good to me.
Regarding the lint that Ian mentioned, here's a lint report that shows the problems:
./lib/lp/ app/widgets/ doc/launchpad- radio-widget. txt code/browser/ codeimport. py code/stories/ branches/ xx-junk- branches. txt code/stories/ codeimport/ xx-create- codeimport. txt registry/ browser/ tests/productse ries-setbranch- view.txt
1: narrative uses a moin header.
38: narrative uses a moin header.
./lib/lp/
361: Line exceeds 78 characters.
270: E261 at least two spaces before inline comment
280: E261 at least two spaces before inline comment
361: E501 line too long (81 characters)
./lib/lp/
33: narrative exceeds 78 characters.
./lib/lp/
43: source exceeds 78 characters.
./lib/lp/
98: source exceeds 78 characters.
115: source exceeds 78 characters.
137: source exceeds 78 characters.
144: want exceeds 78 characters.
164: source exceeds 78 characters.
184: source exceeds 78 characters.
189: want exceeds 78 characters.
203: source exceeds 78 characters.
223: source exceeds 78 characters.
243: source exceeds 78 characters.
263: source exceeds 78 characters.
283: source exceeds 78 characters.
304: source exceeds 78 characters.
370: want exceeds 78 characters.
388: want exceeds 78 characters.
408: source exceeds 78 characters.