Code review comment for lp:~jelmer/launchpad/bzr-code-imports-ui

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks Ian, much appreciated. I've finally found some time to update this MP and address the issues you raised.

xx-create-codeimport.txt has been updated to also test behaviour with regular bzr branches, and I've fixed the bug you mentioned.

I've fixed sourcedeps.cache and the comments about Mercurial and docstring in ProductSeriesSetBranchView._createBzrBranch. I've also enabled authenticated code imports, which are supported by bzr-{svn,hg,git} and bzr.

Removing remote branches was indeed intentional. There was an open bug about removing them, which I have linked to the branch.

"make lint" doesn't display any errors for me - how are you using it, does it need additional configuration?

« Back to merge proposal