Merge lp:~jelmer/launchpad/601013-bzr-builder-import into lp:launchpad

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: 11159
Proposed branch: lp:~jelmer/launchpad/601013-bzr-builder-import
Merge into: lp:launchpad
Diff against target: 47 lines (+12/-3)
3 files modified
lib/lp/code/model/sourcepackagerecipe.py (+1/-1)
lib/lp/registry/model/person.py (+1/-1)
scripts/ftpmaster-tools/sync-source.py (+10/-1)
To merge this branch: bzr merge lp:~jelmer/launchpad/601013-bzr-builder-import
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+29081@code.launchpad.net

Commit message

Support use of newer versions of python-debian and bzr-builder.

Description of the change

Trivial change to consistently import RecipeParser from bzrlib.plugins.builder.recipe and not from bzrlib.plugins.builder.__init__ in some places. The latter module no longer imports RecipeParser from recipe.py in newer versions of bzr-builder.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Jelmer,

As we discussed on IRC, please add an XXX comment regarding the import of Dsc. It should state the condition for removing the alternate location. Will that be when the production machines move to Maverick or a PPA is available?

Also, please make sure your comments are properly punctuated...i.e. full-stop.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/code/model/sourcepackagerecipe.py'
--- lib/lp/code/model/sourcepackagerecipe.py 2010-06-17 14:54:24 +0000
+++ lib/lp/code/model/sourcepackagerecipe.py 2010-07-19 15:34:47 +0000
@@ -10,7 +10,7 @@
10 'SourcePackageRecipe',10 'SourcePackageRecipe',
11 ]11 ]
1212
13from bzrlib.plugins.builder import RecipeParser13from bzrlib.plugins.builder.recipe import RecipeParser
14from lazr.delegates import delegates14from lazr.delegates import delegates
1515
16from storm.locals import (16from storm.locals import (
1717
=== modified file 'lib/lp/registry/model/person.py'
--- lib/lp/registry/model/person.py 2010-07-16 13:34:38 +0000
+++ lib/lp/registry/model/person.py 2010-07-19 15:34:47 +0000
@@ -35,7 +35,7 @@
35import time35import time
36import weakref36import weakref
3737
38from bzrlib.plugins.builder import RecipeParser38from bzrlib.plugins.builder.recipe import RecipeParser
39from zope.lifecycleevent import ObjectCreatedEvent39from zope.lifecycleevent import ObjectCreatedEvent
40from zope.interface import alsoProvides, implementer, implements40from zope.interface import alsoProvides, implementer, implements
41from zope.component import adapter, getUtility41from zope.component import adapter, getUtility
4242
=== modified file 'scripts/ftpmaster-tools/sync-source.py'
--- scripts/ftpmaster-tools/sync-source.py 2010-05-19 18:07:56 +0000
+++ scripts/ftpmaster-tools/sync-source.py 2010-07-19 15:34:47 +0000
@@ -18,7 +18,16 @@
1818
19import apt_pkg19import apt_pkg
20import commands20import commands
21from debian_bundle.deb822 import Dsc21try:
22 from debian.deb822 import Dsc
23except ImportError:
24 # In older versions of python-debian the main package was named
25 # debian_bundle
26 # XXX: Remove this when an up to date version of python-debian lands in
27 # the PPA or Ubuntu. Maverick will be the first release that has an
28 # up to date version of python-debian.
29 from debian_bundle.deb822 import Dsc
30
22import errno31import errno
23import optparse32import optparse
24import os33import os