Merge lp:~jelmer/launchpad/601013-bzr-builder-import into lp:launchpad

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: 11159
Proposed branch: lp:~jelmer/launchpad/601013-bzr-builder-import
Merge into: lp:launchpad
Diff against target: 47 lines (+12/-3)
3 files modified
lib/lp/code/model/sourcepackagerecipe.py (+1/-1)
lib/lp/registry/model/person.py (+1/-1)
scripts/ftpmaster-tools/sync-source.py (+10/-1)
To merge this branch: bzr merge lp:~jelmer/launchpad/601013-bzr-builder-import
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+29081@code.launchpad.net

Commit message

Support use of newer versions of python-debian and bzr-builder.

Description of the change

Trivial change to consistently import RecipeParser from bzrlib.plugins.builder.recipe and not from bzrlib.plugins.builder.__init__ in some places. The latter module no longer imports RecipeParser from recipe.py in newer versions of bzr-builder.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Jelmer,

As we discussed on IRC, please add an XXX comment regarding the import of Dsc. It should state the condition for removing the alternate location. Will that be when the production machines move to Maverick or a PPA is available?

Also, please make sure your comments are properly punctuated...i.e. full-stop.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/model/sourcepackagerecipe.py'
2--- lib/lp/code/model/sourcepackagerecipe.py 2010-06-17 14:54:24 +0000
3+++ lib/lp/code/model/sourcepackagerecipe.py 2010-07-19 15:34:47 +0000
4@@ -10,7 +10,7 @@
5 'SourcePackageRecipe',
6 ]
7
8-from bzrlib.plugins.builder import RecipeParser
9+from bzrlib.plugins.builder.recipe import RecipeParser
10 from lazr.delegates import delegates
11
12 from storm.locals import (
13
14=== modified file 'lib/lp/registry/model/person.py'
15--- lib/lp/registry/model/person.py 2010-07-16 13:34:38 +0000
16+++ lib/lp/registry/model/person.py 2010-07-19 15:34:47 +0000
17@@ -35,7 +35,7 @@
18 import time
19 import weakref
20
21-from bzrlib.plugins.builder import RecipeParser
22+from bzrlib.plugins.builder.recipe import RecipeParser
23 from zope.lifecycleevent import ObjectCreatedEvent
24 from zope.interface import alsoProvides, implementer, implements
25 from zope.component import adapter, getUtility
26
27=== modified file 'scripts/ftpmaster-tools/sync-source.py'
28--- scripts/ftpmaster-tools/sync-source.py 2010-05-19 18:07:56 +0000
29+++ scripts/ftpmaster-tools/sync-source.py 2010-07-19 15:34:47 +0000
30@@ -18,7 +18,16 @@
31
32 import apt_pkg
33 import commands
34-from debian_bundle.deb822 import Dsc
35+try:
36+ from debian.deb822 import Dsc
37+except ImportError:
38+ # In older versions of python-debian the main package was named
39+ # debian_bundle
40+ # XXX: Remove this when an up to date version of python-debian lands in
41+ # the PPA or Ubuntu. Maverick will be the first release that has an
42+ # up to date version of python-debian.
43+ from debian_bundle.deb822 import Dsc
44+
45 import errno
46 import optparse
47 import os