Reviewed per IRC. Notes:
* Run "make lint" before you submit the MP!
* No seriously, run "make lint"!
* Pass exception message to exception constructor. Putting it in _fmt seems unsafe.
* There's no need for proper docstrings on test methods.
* capitalize and punctuate error strings
Otherwise, you're good to go.
Jeroen
« Back to merge proposal
Reviewed per IRC. Notes:
* Run "make lint" before you submit the MP!
* No seriously, run "make lint"!
* Pass exception message to exception constructor. Putting it in _fmt seems unsafe.
* There's no need for proper docstrings on test methods.
* capitalize and punctuate error strings
Otherwise, you're good to go.
Jeroen