Code review comment for lp:~jelmer/bzr/urllib-verifies-ssl-certs

Revision history for this message
Martin Packman (gz) wrote :

Added what's new text is great, and the new logic for printing helpful messages seems good. Some of these messages could probably do with gettext() added, but that can wait for another branch when the rest of the module can be looked over too.

- if cert_reqs == "none":
+ if cert_reqs == ssl.CERT_NONE:

Seen in the interdiff for the last change, was this broken before, and did a test fail because of it?

review: Approve

« Back to merge proposal