Code review comment for lp:~jelmer/bzr/uncommit-remove-tags

On 08/24/2011 11:46 AM, John A Meinel wrote:
> On 8/24/2011 7:30 AM, Martin Pool wrote:
>> Review: Approve That's good.
>>
>> [tweak] It's a bit safer to add new keyword parameters at the end.
>>
>> [tweak] Please mention it in the user guide under uncommit.
> I'm a bit concerned that we do a graph search to find what tags to
> remove. I guess we've only been doing a linear search to resolve what
> revisions to display?
>
Yep. We could potentially avoid redoing the get_parent_map calls for the
revisions on the mainline, but at the cost of more code complexity.

Cheers,

Jelmer